fix(a11y) Make Dropdown more accessible #2333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montogeek
reviewed
Jul 5, 2018
| @@ -45,8 +45,8 @@ export default class Navigation extends React.Component { | |||
| <Dropdown | |||
| className="navigation__languages" | |||
| items={[ | |||
| { title: 'English', url: 'https://webpack.js.org/' }, | |||
| { title: '中文', url: 'https://doc.webpack-china.org/' } | |||
| { lang: 'en', title: 'English', url: 'https://webpack.js.org/' }, | |||
There was a problem hiding this comment.
What is the reason of this change?
There was a problem hiding this comment.
It's my mistake. This shouldn't be there. Thanks for taking a look :)
- make it focusable - allow navigation using arrow keys - dismiss on escape
tryzniak
force-pushed
the
fix/a11y-dropdown-rebuild
branch
from
a0626b0 to
b630674
Compare
montogeek
reviewed
Jul 13, 2018
| @@ -46,7 +46,7 @@ export default class Navigation extends React.Component { | |||
| className="navigation__languages" | |||
| items={[ | |||
| { title: 'English', url: 'https://webpack.js.org/' }, | |||
| { title: '中文', url: 'https://doc.webpack-china.org/' } | |||
| { lang: 'zh', title: '中文', url: 'https://doc.webpack-china.org/' } | |||
There was a problem hiding this comment.
It is fine to left English language with an empty lang attribute?
There was a problem hiding this comment.
Yeah, because we have already set lang globally with , so we don't have to set it here.
montogeek
approved these changes
Jul 13, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of #2325